rfctr(pptx): minify HTML and table.text is cct #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scanny
force-pushed
the
scanny/minify-pptx-html
branch
5 times, most recently
from
e3a55ff
to
8280dac
Compare
scanny
force-pushed
the
scanny/minify-pptx-html
branch
from
8280dac
to
f2923e3
Compare
scanny
commented
Oct 19, 2024
Comment on lines
-216
to
-220
| def _iter_title_shape_element(self, shape: Shape) -> Iterator[Element]: | ||
| """Generate Title element for each paragraph in title `shape`. | ||
|
|
||
| Text is most likely a title, but in the rare case that the title shape was used | ||
| for the slide body text, also check for bulleted paragraphs.""" |
There was a problem hiding this comment.
This was just out of order, so moved without code changes.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Eliminate historical "idiosyncracies" of
table.metadata.text_as_htmlHTML introduced bypartition_pptx(). Produce minified.text_as_htmlconsistent with that formed by chunking.Additional Context
.metadata.text_as_htmlis minified (no extra whitespace or thead, tbody, tfoot elements).table.textis clean-concatenated-text (CCT) of table.tabulatelibrary is removed and that dependency is removed frombase.in.