rfctr(csv): minify HTML and table text is cct #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coniferish
approved these changes
Oct 18, 2024
scanny
force-pushed
the
scanny/minify-csv-html
branch
8 times, most recently
from
c0a5840
to
a6c5baf
Compare
Include TSV in the mix since they are essentially clones of each other.
scanny
force-pushed
the
scanny/minify-csv-html
branch
from
a6c5baf
to
25656eb
Compare
… update (#3736) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: scanny <[email protected]>
… update (#3737) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: scanny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Eliminate historical "idiosyncracies" of
table.metadata.text_as_htmlHTML introduced bypartition_csv(). Produce minified.text_as_htmlconsistent with that formed by chunking.Additional Context
.metadata.text_as_htmlis minified (no extra whitespace or thead, tbody, tfoot elements).table.textis clean-concatenated-text (CCT) of table.