-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ingest python doc #1446
Merged
Merged
update ingest python doc #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryannikolaidis
approved these changes
Sep 19, 2023
Closed
rbiseck3
force-pushed
the
roman/update-ingest-python-docs
branch
from
September 21, 2023 16:23
035ef6a
to
b7024b7
Compare
rbiseck3
force-pushed
the
roman/update-ingest-python-docs
branch
3 times, most recently
from
October 2, 2023 17:07
0a0b63b
to
00146ee
Compare
rbiseck3
force-pushed
the
roman/update-ingest-python-docs
branch
from
October 3, 2023 13:04
00146ee
to
178c547
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the python version of the example docs to show how to run the same code that the CLI runs, but using python. Rather than copying the same command that would be run via the terminal and using the subprocess library to run it, this updates it to use the supported code exposed in the inference directory.
For now only the wikipedia one has been updated to get some opinions on this before updating all other connector docs.
Would close out #1445