Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Snyk ignore policy for unreachable/false-positive reported vulnerabilities #854

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

pwnslinger
Copy link
Contributor

Description

Snyk reported vulnerabilities recently that have no direct upgrade yet or were false-positive. We just updated the lerna to major version ^5.0.0

Tasks

  • Ignored until 2024-01-01 as no viable patch or suggestion is available. Plus, the reported vulnerabilities were false-positive.
  • MPL-2 license issue introduced through Coinbase Wallet should be reported to them.

 snyk ignore --id='SNYK-JS-NWSAPI-2841516' --expirty='2024-01-01' --reason='no direct update or patch available suggested for jest / most probably vuln is not reachable'
 snyk ignore --id='SNYK-JS-TOUGHCOOKIE-5672873' --expirty='2024-01-01' --reason='no patch or suggestion is available by jest'
 snyk ignore --id='SNYK-JS-WORDWRAP-3149973' --expirty='2024-01-01' --reason='ReDoS is valid when there is a path between the source (user uncontrolled input) to a sink that is a regex parser but in this case is not applicable'
 snyk ignore --id='snyk:lic:npm:rlp:MPL-2.0' --expirty='2024-01-01' --reason='introduced through Coinbase Wallet and should be discussed with them - MPL 2.0'
 snyk ignore --id='snyk:lic:npm:ethereumjs-util:MPL-2.0' --expirty='2024-01-01' --reason='introduced through Coinbase Wallet and should be discussed with them - MPL 2.0'

How Has This Been Tested?

Running snyk test locally to ensure the .ignore file and policies works.

➜  web3-react git:(build/snyk-ignore) snyk test --dev

Testing /Users/mohsen.ahmadi/web3-react...

Organization:      uniswap-poc
Package manager:   yarn
Target file:       yarn.lock
Project name:      web3-react
Open source:       no
Project path:      /Users/mohsen.ahmadi/web3-react
Local Snyk policy: found
Licenses:          enabled

✔ Tested 1059 dependencies for known issues, no vulnerable paths found.

@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3-react ✅ Ready (Inspect) Visit Preview Jul 7, 2023 5:12pm

@pwnslinger pwnslinger requested a review from zzmp July 7, 2023 17:12
Copy link
Contributor

@zzmp zzmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the verbose reasons - it makes it much more maintainable ❤️

@zzmp zzmp merged commit 505e164 into main Jul 7, 2023
6 checks passed
@zzmp zzmp deleted the build/snyk-ignore branch July 7, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants