Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure the initialization to throw an exception when there is no match url #718

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nikli2009
Copy link

A minor checking added to network initialization.

Context

Found this when launching Uniswap interface locally and chose the Evmos chain.
The original error I got is :
image

So I looked into it a bit and seems we have a assumption that urls will not be empty which in fact it could be.

and 🤔 I reckon there is something we could do about it like :

  • Exit early when conditions check fails
  • Make sure the user of web3-react can capture this Unhandled Rejection with a more meaningful error name.

Plz let me know if this makes sense to you :D

Changes

  • Add additional urls null check.
  • Add unit test for the edge case.

@vercel
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
web3-react ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 6:40AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant