Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool screen shows values with 24hr but its actually only the same day #314

Open
Reedyuk opened this issue Feb 6, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Reedyuk
Copy link

Reedyuk commented Feb 6, 2024

Bug Description
Lets use the pool uni / USDT - when you view the pool
https://info.uniswap.org/#/pools/0x3470447f3cecffac709d3e783a307790b0208d60
Then you will see that the left stats show: (this is for 6th Feb 2024)
Volume 24h $15.19k 24h Fees $45.58

From what i can see, this seems to be the value from thegraph of the poolDayDatas, but they come in chunks of days(not 24hr from now) so the actual data is not the last 24hr, but just todays (6th Feb 2024 12:00:00 AM) - at the time of writing thats 21hrs.

I think possibly its just the wording, but i would expect 24hr to represent the last 24hrs.

Steps to Reproduce

  1. Go to https://info.uniswap.org/#/pools/0x3470447f3cecffac709d3e783a307790b0208d60
  2. View the stats on the left

Expected Behavior
Either a change of the wording of 24hr OR to adjust the graph data and try and calculate true 24hr difference(would probably produce a large overhead).

@Reedyuk Reedyuk added the bug Something isn't working label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant