Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Doc for Limit Integrations #660

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Adding Doc for Limit Integrations #660

merged 2 commits into from
Feb 28, 2024

Conversation

akarys92
Copy link
Collaborator

Adding docs for new limit order integration.

@robert-seitz-uniswap to add URL when ready.

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 6:21pm

The process for retrieving and executing limit orders is the same as Dutch Orders above except that Limit Orders will be retrieved from the [Limit Orders Endpoint](TODO) and executed against the [Limit Order Reactor](https://github.com/Uniswap/UniswapX/blob/main/src/reactors/LimitOrderReactor.sol). The process is:

1. Call `GET` on the `/TODO` of the UniswapX Limit Orders Endpoint as written above, to retrieve open signed orders
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robert-seitz-uniswap Add the link here when ready please!

@marktoda
Copy link

yup lgtm

Copy link
Contributor

@dannydaniil dannydaniil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akarys92 akarys92 merged commit ae52369 into main Feb 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants