Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volumetric Datasource does not realloc memory on dataset change #1236

Open
moritz-h opened this issue Nov 3, 2023 · 0 comments
Open

Volumetric Datasource does not realloc memory on dataset change #1236

moritz-h opened this issue Nov 3, 2023 · 0 comments
Labels

Comments

@moritz-h
Copy link
Member

moritz-h commented Nov 3, 2023

Describe the bug
When changing a dataset in the volumetric datasource no memory reallocation happens. If the new dataset is larger is will crash with a segfault. Here is a comment that explicitly states to just use the memory as is:

/*
* The caller requests us to copy directly to the memory that is
* provided in the call. We assume this memory to be contiguous
* and large enough to hold all requested frames.
*/

But someone must be responsible to do a reallocation somewhere if the dataset changes. With the initial loading the allocation happens in the if case right above the comment.

Steps To Reproduce

  1. Load volume example (i.e. raycast_volume_renderer.lua)
  2. Change file in volumetric datasource to a larger file (at runtime with GUI)
  3. See segfault
@moritz-h moritz-h added the bug label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant