New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanity Check has high performance impact. #587

Open

MaZiFAU opened this issue Jan 19, 2024 · 0 comments

Collaborator

MaZiFAU commented Jan 19, 2024

This "sanity check":

MMT/src/frameit-mmt/src/info/kwarc/mmt/frameit/communication/server/ConcreteServerEndpoints.scala

Line 225 in 297b0e1

    
           require(state.check().isEmpty, "Situation space doesn't typecheck after scroll application, " +

incurres a high performance impact (about x60 compared without check, e.g. with "http://mathhub.info/FrameIT/frameworld?RiverScrollSimple") amounting to several seconds (e.g. 12.2s vs 0.2s).

There seem to be no consequences of commenting it out when everything type-checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment