Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Guide in GUI #19

Merged
merged 5 commits into from
Mar 25, 2023
Merged

Setup Guide in GUI #19

merged 5 commits into from
Mar 25, 2023

Conversation

uier
Copy link
Contributor

@uier uier commented Feb 22, 2023 •
edited
Loading

close #17

Progress:

  • home page UI
  • home page TS logic
  • auth page TS logic
  • PATCH user role API SET lables for user by roles in register POST method
  • MERGE a first invitation code at server setup
  • Update README

@uier uier marked this pull request as ready for review March 18, 2023 12:31
@uier
Copy link
Contributor Author

uier commented Mar 20, 2023

Hey guys, this PR is ready for review.

If you wanna test the GUI of this feature, you could remove the volumes (except vscode) to initialize the database. This feature only shows up at the beginning.

JacobLinCool
JacobLinCool requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@JacobLinCool JacobLinCool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The on-board animation is impressive, but there seems to be an issue with the pre-filled invitation code. It's not functioning as intended. I've shared my thoughts on this in the review, and further discussions are welcome.

Thanks for your contribution.

.env.example Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/routes/+page.svelte Outdated Show resolved Hide resolved
Bogay
Bogay reviewed Mar 20, 2023
View reviewed changes
README.md Show resolved Hide resolved
@skyhong2002 skyhong2002 mentioned this pull request Mar 21, 2023
Open
@uier uier requested review from Bogay and JacobLinCool and removed request for Bogay March 24, 2023 14:16
JacobLinCool
JacobLinCool approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@JacobLinCool JacobLinCool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the pull request! I think that it can be merged now. Thanks for your hard work and attention to detail!

This was referenced Mar 24, 2023
Closed
Open
@JacobLinCool JacobLinCool added this pull request to the merge queue Mar 25, 2023
Merged via the queue into main with commit 70b8f6e Mar 25, 2023
@JacobLinCool JacobLinCool deleted the feat-setup-guide branch May 19, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobLinCool JacobLinCool JacobLinCool approved these changes

@Bogay Bogay Bogay approved these changes

@skyhong2002 skyhong2002 Awaiting requested review from skyhong2002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Setup Guide in GUI
4 participants
@uier @Bogay @JacobLinCool @skyhong2002