Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Environment Variable Naming Convention for R2/S3 #56

Open
JacobLinCool opened this issue May 19, 2023 · 0 comments
Open

Update Environment Variable Naming Convention for R2/S3 #56

JacobLinCool opened this issue May 19, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@JacobLinCool
Copy link
Member

Given that R2 is simply a drop-in alternative for S3 (with S3 libraries being used internally), it appears that the CLOUDFLARE_ prefix in CLOUDFLARE_R2_ENDPOINT, CLOUDFLARE_ACCESS_KEY_ID, and CLOUDFLARE_SECRET_ACCESS_KEY should be removed.

I propose using S3_ENDPOINT, S3_ACCESS_KEY_ID, and S3_SECRET_ACCESS_KEY as the environment variables instead.

@Bogay Bogay added the documentation Improvements or additions to documentation label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants