Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Allow skipping crop if page boundary is not visible in CropPage #215

Open
Udayraj123 opened this issue Sep 23, 2024 · 3 comments
Labels

Comments

@Udayraj123
Copy link
Owner

Is your feature request related to a problem? Please describe.
In case of combined CropPage + CropOnMarkers usecase, sometimes the page boundary is not visible but the markers can still be detected. Currently in this case CropPage raises an error for the image since it thinks the image is not fit for processing further.

Describe the solution you'd like
We should allow a flag shouldFailIfPageNotFound which would be set to true by default. On setting it as false, the CropPage processor should return the input image without cropping.

Describe alternatives you've considered
Another alternative is to create a new processor that does this instead of a flag, but seems unnecessary as of now.

Additional context

@Prasadayus
Copy link

Hi @Udayraj123 I want to work on this

@Udayraj123
Copy link
Owner Author

@Prasadayus Sure, you can share a basic approach and i'll assign it to you

@palash018
Copy link
Contributor

@Prasadayus Are you actively working on this? else i'd like to move forward with this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants