Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add snapshot path by default to report directories #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ratulm
Copy link
Contributor

@ratulm ratulm commented Apr 25, 2023

Allow users to fully customize where they want the report to be dumped. Often, they may want to treat the snapshot directory as read-only.

Also, the previous code wouldn't have worked if lcov_path or html_path were absolute paths because it was unconditionally prepending the snapshot path.

@ratulm ratulm requested a review from xieyangxu April 25, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant