Bootcamp - Davis Liu #109
Open
Bootcamp - Davis Liu #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronWang04
reviewed
Sep 29, 2024
Comment on lines
+81
to
+90
| if report.status == drone_status.DroneStatus.HALTED: # if command done | ||
| if self.command_index < len(self.commands): # next command | ||
| print(f"frame({self.counter}) cmd({self.command_index}) pos({report.position})") | ||
| command = self.commands[self.command_index] | ||
| self.command_index += 1 | ||
| elif not self.has_sent_landing_command: # start landing | ||
| command = commands.Command.create_land_command() | ||
| self.has_sent_landing_command = True | ||
|
|
||
| self.counter += 1 |
There was a problem hiding this comment.
note that we have a acceptance_radius attribute
due to drone position being analog, this is often required when checking if we have reached a location. it is important to double check after the drone has halted that the drone is indeed at the location specified in the command
| @@ -69,6 +79,34 @@ def run( | |||
| # ============ | |||
|
|
|||
| # Do something based on the report and the state of this class... | |||
| pos_x = report.position.location_x | |||
| pos_y = report.position.location_y | |||
| if report.status == drone_status.DroneStatus.HALTED: # if command done | |||
There was a problem hiding this comment.
apply the double check with location here as well
Comment on lines
+125
to
+126
| if not result: | ||
| return [], image_annotated # data is invalid |
There was a problem hiding this comment.
nice job returning the whole dataset as wrong, this is common practice done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.