Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface translations #451

Open
2 of 3 tasks
BeritJanssen opened this issue Mar 31, 2021 · 2 comments · Fixed by #513
Open
2 of 3 tasks

Interface translations #451

BeritJanssen opened this issue Mar 31, 2021 · 2 comments · Fixed by #513
Assignees
@jgonggrijp
Labels
enhancement New feature or request
Milestone
Extra mile

Comments

@BeritJanssen
Copy link
Member

BeritJanssen commented Mar 31, 2021 •
edited by JeltevanBoheemen
Loading

  • Get translations of interface elements
  • Add translations to interface
  • Enable user to switch language (rather than just auto-detect)
@BeritJanssen BeritJanssen added the enhancement New feature or request label Mar 31, 2021
@BeritJanssen BeritJanssen added this to the Extra mile milestone Mar 31, 2021
@jgonggrijp jgonggrijp self-assigned this Mar 31, 2021
@jgonggrijp
Copy link
Member

UUDigitalHumanitieslab/handlebars-i18next#7

@jgonggrijp jgonggrijp linked a pull request Nov 30, 2021 that will close this issue
Feature/interface clarifications #513
Merged
jgonggrijp added a commit that referenced this issue Mar 15, 2022
@jgonggrijp
Add {{#i18n}} tags to the source-related templates (#451 #37)
731c44f 
Adding these changes here as part of #517 instead of in #513 because
the latter is outdated compared to the former with regard to these
templates.

@JeltevanBoheemen FYI
jgonggrijp added a commit that referenced this issue Mar 15, 2022
@jgonggrijp
Fix markup of modal close button in feedback template (#451)
9ddf02f
jgonggrijp added a commit that referenced this issue Mar 15, 2022
@jgonggrijp
Correct indentation in pagination template (#451)
9dea827
jgonggrijp added a commit that referenced this issue Mar 15, 2022
@jgonggrijp
Properly nest, don't escape markup in i18n in anno edit template #451
7af7b78
jgonggrijp added a commit that referenced this issue Mar 15, 2022
@jgonggrijp
Add {{#i18n}} tags in more places (#451)
e440981 
Some parts of some templates seem to have previously escaped attention,
especially placeholder, data-tooltip and aria-label attributes. Besides
those, there were some changes that were added in parallel on develop,
as well as a few pieces where alternative orthography or sentence
structure of other languages needed to be taken into account.
jgonggrijp added a commit that referenced this issue Mar 16, 2022
@jgonggrijp
Add i18next.t calls to the source-related views (#451 #37)
d7d0d31 
Adding these changes here as part of #517 instead of in #513 because
the latter is outdated compared to the former with regard to these
views. This is a follow-up on the previous commit, which regarded the
templates.

@JeltevanBoheemen FYI
jgonggrijp added a commit that referenced this issue Mar 17, 2022
@jgonggrijp
Add i18next.t calls in more places (#451)
1236e78
jgonggrijp added a commit that referenced this issue Mar 17, 2022
@jgonggrijp
Export i18nParse function in gulpfile as task (#451)
c482a9b
jgonggrijp added a commit that referenced this issue Mar 17, 2022
@jgonggrijp
Import { gulp as i18nextParser } (#451)
164f7fb
jgonggrijp added a commit that referenced this issue Mar 17, 2022
@jgonggrijp
Use frontend/src/i18n as the i18nParser output directory (#451)
d59b9eb
jgonggrijp added a commit that referenced this issue Mar 17, 2022
@jgonggrijp
Point i18nParser to the files inside the source directory (#451)
8408b98
jgonggrijp added a commit that referenced this issue Mar 17, 2022
@jgonggrijp
Configure hbs lexer for i18nParse gulp task (#451)
54e4d43
jgonggrijp added a commit that referenced this issue Mar 31, 2022
@jgonggrijp
Use our very own handlebars-i18next-parser (#451)
e63744b
jgonggrijp added a commit that referenced this issue Apr 20, 2022
@jgonggrijp
Move i18next-parser config to a separate file (#451)
91ad84b 
In their infinite wisdom, the i18next-parser team decided to go ESM-
only, which obviously doesn't work with a TS gulpfile that is still
emulating ESM on top of CommonJS. Sigh.
jgonggrijp added a commit that referenced this issue Apr 20, 2022
@jgonggrijp
Use the output of i18next-parser (#451)
4e1cf4b
jgonggrijp added a commit that referenced this issue Apr 20, 2022
@jgonggrijp
Document frontend localization with the new parsing setup (#451)
9f92958
jgonggrijp added a commit that referenced this issue Apr 20, 2022
@jgonggrijp
Document the shorthand script in the top-level package.json (#451)
4176497
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Use the output of i18next-parser (#451)
14b38eb
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Document frontend localization with the new parsing setup (#451)
d2a3f8f
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Document the shorthand script in the top-level package.json (#451)
fc250c9
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Add i18n keys that i18next-parse cannot handle automatically (#451)
be0f64d
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Fix a discrepancy in i18n "close" key (#451)
e2b0e4d
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Move anno-edit type hints entirely into translation JSON (#451)
9929899 
This also adds dynamism so that the translation strings cannot be
requested before they are available.
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Stop i18next-parser from changing French back to English (#451)
5f0daf0
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Use four-space indentation in translation JSON files (#451)
6b665cb
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Replace _ by - in i18n keys (#451)
4a10968 
The underscore is the context and number separator in i18next. At the
time of writing we are not using this anywhere yet. To avoid confusion,
use a dash as a word separator.
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Place variable interpolations inside i18n strings where appropriate (#…
11af496 
…451)
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Commit translation_old.json (#451)
3b0352e 
i18next-parse is stateful. Apparently, the contents of the
translation_old.json are taken into account, too.
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Upgrade handlebars-i18next-parser to 1.0.2 (#451)
978c0f5
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Treat translation strings with links consistently (#451)
6cf200a
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Organize the translation strings (#451)
a6a9e83
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Document how to prevent i18next-parser translation overrides (#451)
34900a9
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Make i18n changes consistent with 4a10968, 6cf200a, a6a9e83 (#451)
0d05d80
jgonggrijp added a commit that referenced this issue May 2, 2022
@jgonggrijp
Make i18n changes consistent with 4a10968, 6cf200a, a6a9e83 (#451)
193f053
jgonggrijp added a commit that referenced this issue Jun 13, 2022
@jgonggrijp
Use native Promise for global/i18n (#451)
08440c4
jgonggrijp added a commit that referenced this issue Jun 13, 2022
@jgonggrijp
Expose i18nPromise through radio channel for access from views (#451)
1d71075
jgonggrijp added a commit that referenced this issue Jun 13, 2022
@jgonggrijp
Use the new i18nChannel where appropriate (#451)
1697cfd
@jgonggrijp
Copy link
Member

Reopening because the user-controllable language switch hasn't been implemented yet.

@jgonggrijp jgonggrijp reopened this Jun 30, 2022
jgonggrijp added a commit that referenced this issue Apr 14, 2023
@jgonggrijp
Default unused translation string to empty string (#37 #451)
0c84850
jgonggrijp added a commit that referenced this issue Apr 14, 2023
@jgonggrijp
Regenerate the translation files (#37 #517 #451)
82c8278
jgonggrijp added a commit that referenced this issue May 20, 2023
@jgonggrijp
Default unused translation string to empty string (#37 #451)
082fe87
jgonggrijp added a commit that referenced this issue May 20, 2023
@jgonggrijp
Regenerate the translation files (#37 #517 #451)
2600570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgonggrijp jgonggrijp

Labels
enhancement New feature or request
Projects
None yet
Milestone
Extra mile
Development

Successfully merging a pull request may close this issue.

Feature/interface clarifications UUDigitalHumanitieslab/readit-interface
2 participants
@jgonggrijp @BeritJanssen