Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Match what is in the SDM paper #96

Open
jsadler2 opened this issue Apr 16, 2021 · 2 comments
Open

Match what is in the SDM paper #96

jsadler2 opened this issue Apr 16, 2021 · 2 comments

Comments

@jsadler2
Copy link
Collaborator

Xiaowei has a slightly different, simpler version of the RGCN in the SDM paper. I think this is more understandable and it'd be good to change to it:
image
image

@SimonTopp
Copy link
Contributor

I believe this is implemented in the PyTorch version by @jdiaz4302. @jsadler2, do you think we should implement it in the TF version as well still?

@jdiaz4302
Copy link
Collaborator

Yep, that's what going on here: https://github.com/USGS-R/river-dl/blob/main/river_dl/torch_models.py#L164-L165

That # note: self.A @ q_t could be taken out, I believe that's a development relic/reminder that I didn't remove; it doesn't add anything/act as an informative comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants