Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area for storage exfiltration #167

Open
NandanaPerera opened this issue Mar 12, 2024 · 0 comments
Open

Area for storage exfiltration #167

NandanaPerera opened this issue Mar 12, 2024 · 0 comments
Assignees
Milestone

Comments

@NandanaPerera
Copy link

Bank area contributing to storage infiltration in exfil_getLoss (exfil.c) is computed by:
area = MIN(area, exfil->bankMaxArea) - exfil->btmArea;

This seems to be assuming storage area is continuously increasing (similar to storage pond). For a storage curve that has a maximum area in the middle (such as an underground chamber as below - this also has gravel layers at the bottom and top with reduced area from porosity), infiltrating bank area above the bankMaxDepth should consider the bankMaxArea.

image

@cbuahin cbuahin self-assigned this Mar 13, 2024
@cbuahin cbuahin added the bug label Mar 13, 2024
@cbuahin cbuahin added this to the v5.3.0 milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants