Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Basin Lat Long in favor of on the fly calculation #97

Closed
micahjohnson150 opened this issue Aug 22, 2019 · 4 comments
Closed

Remove Basin Lat Long in favor of on the fly calculation #97

micahjohnson150 opened this issue Aug 22, 2019 · 4 comments
Assignees
@micahjohnson150
Labels
enhancement
Milestone
Wy2020 Fixes

Comments

@micahjohnson150
Copy link
Contributor

We would like to remove the basin lat and long from the config file in exchange for calculating it on the fly from the topo.nc
@micahjohnson150 micahjohnson150 added this to the Wy2020 Fixes milestone Aug 22, 2019
@micahjohnson150 micahjohnson150 self-assigned this Aug 22, 2019
@micahjohnson150
Copy link
Contributor Author

@scotthavens how do you feel about this being abstracted and added to spatialnc?
It feels to me like it might be used in other places besides smrf, at the very least it might be used by you guys for papers and analysis.

@scotthavens
Copy link
Contributor

Where else does this get used? I don't see this being used many other places at a the moment. I can see #100 being moved to spatialnc since katana and others would use it.

@micahjohnson150
Copy link
Contributor Author

The function I wrote to calculate the center is what I was thinking might go into spatialnc. You are right I don't think it gets used anywhere but I thought if might be useful for general analysis stuff.

Thats a good call on #100, I will try to add that to spatialnc.

@scotthavens
Copy link
Contributor

The basin lat/lon is only used in the solar angle calucation that was improved on it PR #141. Down the road, we can calculate the sun angle for every point on the basin which would allow us to remove this.

@micahjohnson150 micahjohnson150 mentioned this issue Apr 15, 2020
Merged
micahjohnson150 added a commit that referenced this issue Apr 15, 2020
@micahjohnson150
Removed all the gridded zone numbers and zone letter references to th…
1c2108b 
…e config file. Updated the config file and autocalculated the basin_lat long. Fixed #100 and #97
micahjohnson150 added a commit that referenced this issue Apr 30, 2020
@micahjohnson150
Auto assign basin projection attributes and basin center (#154)
a09ad0d 
* Updated utm py package, Removed basin lat/lon for autocalc, assigned all lat log references to the topo class, retrieving zone number from the topo.nc, added a northern hemisphere config option to avoid rewriting topos files since they dont have the zone number. Removed a couple deprecated recipes relating to topo

* Updating the tests, added in a center finding for the basin mask only

* Added in a loadtopo test

* Removed all the gridded zone numbers and zone letter references to the config file. Updated the config file and autocalculated the basin_lat long. Fixed #100 and #97

* Removed all the class attributes in loadGrid so they directly refer to the topo class, added a test to insure these attributes stay.

* DRYing out load grid while I am here

* Updated gold config files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micahjohnson150 micahjohnson150

Labels
enhancement
Projects
None yet
Milestone
Wy2020 Fixes
Development

No branches or pull requests
2 participants
@micahjohnson150 @scotthavens