Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for model repository revisions #1373

Closed
Muennighoff opened this issue Jan 13, 2022 · 2 comments · Fixed by #2419
Closed

Support for model repository revisions #1373

Muennighoff opened this issue Jan 13, 2022 · 2 comments · Fixed by #2419

Comments

@Muennighoff
Copy link
Contributor

I'm facing some difficulties of using this repository in production due to its limited support for commit strings / revisions. Would it be possible to implement the below two changes:

a) Allow the huggingface revision kwarg to be fed into SentenceTransformer(..) which is then fed into snapshot_download to know for sure a certain model version is downloaded?
b) Not overwrite the default huggingface filename in snapshot_download? By default huggingface seems to keep the revision in the filename. This can then be used to detect the revision downloaded from the environment. Overwriting it with force_filename=relative_filepath causes us to lose this piece of information... :(

Thanks for this amazing repo!

@JohnPaton
Copy link

+1, right now I guess the workaround would be to use huggingface to download the model with revision and then load it in sentence-transformers from disk, but it's not really nice.

@tomaarsen
Copy link
Collaborator

Implemented in #2419, it will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants