Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup: Emails sent for "Is X a member" even when user not created.. #83

Open
castaway opened this issue May 12, 2017 · 1 comment
Open
Assignees
Labels

Comments

@castaway
Copy link
Contributor

This maybe a specific and somewhat minor issue to me using my local mail server - externally any email @mydomain is delivered to me (unless specfically aliased to something else).. but if I send to it internally, non-users get rejected.. thus foo@domain errored, user account wasnt created.. but space email got sent a "Is foo@domain a member"?

@castaway
Copy link
Contributor Author

it occurs to me this will also happen if a user mistypes the domain of the email - so probably still needs fixing .. send to user first, and only to contact if that worked?

@castaway castaway added the ready label Aug 14, 2017
castaway added a commit that referenced this issue Aug 18, 2017
* Ensures we don't send it if user-email send fails
* In try/catch block in case it fails too
* Fixes bug #83
@castaway castaway self-assigned this Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants