Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run install-types is slow #396

Closed
Manu1400 opened this issue Jun 23, 2020 · 6 comments
Closed

npm run install-types is slow #396

Manu1400 opened this issue Jun 23, 2020 · 6 comments

Comments

@Manu1400
Copy link

Manu1400 commented Jun 23, 2020

Subject of the issue

The command npm run install-types on definitelyTypedTests directory run git clone https://github.com/DefinitelyTyped/DefinitelyTyped.git ../DefinitelyTyped command but it's so slow.

Your environment

  • ts-auto-mock version: lasted

Steps to reproduce

  1. cd definitelyTypedTests/
  2. npm install on definitelyTypedTests directory
  3. npm run install-types to install/download types from definitelyTyped
  4. Wait one minute with a xDSL internet
  5. Cmd + C to kill the command (because it's too slow)

Expected behavior

Prefer git clone --depth 10 https://github.com/DefinitelyTyped/DefinitelyTyped.git ../DefinitelyTyped

@Manu1400
Copy link
Author

Manu1400 commented Jun 23, 2020

In verbose mode without --depth 10:

Receiving objects: 59% (303435/508182), 302.25 MiB

@uittorio
Copy link
Member

@Manu1400 thanks for opening this issue :) we'll fix that soon! I didn't know about --depth

@uittorio
Copy link
Member

I've opened a PR. I've decided to use 1 instead of 10. Is there any reason why you've shown 10 in the example?

#399

@Pmyl
Copy link
Collaborator

Pmyl commented Jun 26, 2020

PR #339 merged in master, @Manu1400 let me know if it does what you expect so I can close this issue

@uittorio
Copy link
Member

Closing because is fixed :) Thanks again for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants