Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the Api library testable #15

Open
LuckyNoS7evin opened this issue Apr 7, 2018 · 2 comments
Open

Making the Api library testable #15

LuckyNoS7evin opened this issue Apr 7, 2018 · 2 comments

Comments

@LuckyNoS7evin
Copy link
Member

So the Api is not really testable at the moment due to its dependency on HttpClient (>2.0) and WebRequest (<2.0)

Therefore I propose the following:-

  1. Break out the actual calls made into a different class
  2. create an interface
  3. profit

With the aim of making the Api more DI friendly this would mean a new constructor value in which a "HttpCallHandler" can be injected

@jaybyrrd
Copy link

jaybyrrd commented Jul 5, 2018

We should probably create an issue for each section so that people can work on these independant of eachother. I know there is a pr out there setting the baseline for this.

@LuckyNoS7evin
Copy link
Member Author

good shout, at the moment we have a few helix ones in there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants