Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider off-thread Chunkloading before Teleport #888

Open
BlayTheNinth opened this issue Aug 19, 2024 · 0 comments
Open

Consider off-thread Chunkloading before Teleport #888

BlayTheNinth opened this issue Aug 19, 2024 · 0 comments
Labels
needs discussion This may be considered in the future and I'm looking for more opinions

Comments

@BlayTheNinth
Copy link
Member

A somewhat frequent report with Waystones is that servers are experiencing lagspikes or clients are falling through the ground on teleports.

Since nowadays chunk loading does support CompletableFuture to some extent, it might be time to look into whether the teleport's chunk load could be initiated off the main thread.

Some things to watch out for:

  • what if player moves away
  • what if the waystone is broken
  • what if player drops the stone or scroll
  • what if player uses the stone or scroll again
  • what if player dies
  • what if leashed entities or pets change
@BlayTheNinth BlayTheNinth added the needs discussion This may be considered in the future and I'm looking for more opinions label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion This may be considered in the future and I'm looking for more opinions
Projects
Status: 📝 Planning
Development

No branches or pull requests

1 participant