Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations and default ADTypes #2156

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Fix deprecations and default ADTypes #2156

merged 2 commits into from
Jan 20, 2024

Conversation

devmotion
Copy link
Member

Some of the default ADType settings for NUTS are not qualified which causes test errors in DynamicPPL. Additionally, this PR fixes the deprecation of setadbackend which was deprecated as setbackend.

Fixes #2155.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (99a121c) 0.00% compared to head (751c4e2) 0.00%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/mcmc/hmc.jl 0.00% 4 Missing ⚠️
src/mcmc/emcee.jl 0.00% 3 Missing ⚠️
src/deprecated.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2156   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          22      22           
  Lines        1396    1396           
======================================
  Misses       1396    1396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devmotion devmotion merged commit bb45a1f into master Jan 20, 2024
13 checks passed
@devmotion devmotion deleted the dw/adtypes_fixes branch January 20, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: setadbackend
2 participants