Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForwardDiff Optimization test failing #2369

Open
penelopeysm opened this issue Oct 22, 2024 · 1 comment
Open

ForwardDiff Optimization test failing #2369

penelopeysm opened this issue Oct 22, 2024 · 1 comment
Labels
upstream: to report Upstream bugs which haven't been reported

Comments

@penelopeysm
Copy link
Member

penelopeysm commented Oct 22, 2024

elseif adbackend isa AutoForwardDiff
# TODO: Figure out why this is happening.
# https://github.com/TuringLang/Turing.jl/issues/2369
@test_throws DivideError maximum_likelihood(m; adtype=adbackend)
@test_throws DivideError maximum_a_posteriori(m; adtype=adbackend)
else

Marking as @test_throws for now, but we should try to get to the bottom of it and re-enable the test.

@penelopeysm
Copy link
Member Author

penelopeysm commented Oct 22, 2024

Note that this didn't happen in older versions of Turing, #2341 seems to have introduced this and it's not clear why (it might not be code changed in that PR, it might just generally be newer versions of deps).

It also seems very likely that this is an upstream error, not a Turing one, although I haven't looked at it in any depth.

@penelopeysm penelopeysm added the upstream: to report Upstream bugs which haven't been reported label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream: to report Upstream bugs which haven't been reported
Projects
None yet
Development

No branches or pull requests

1 participant