Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pen: "Stage selected: less pen blocks" label on the stage #189

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

CST1229
Copy link

@CST1229 CST1229 commented Jan 29, 2024

Proposed Changes

Adds a label to the Pen category when on the stage:
image

Reason for Changes

The motion category already does a similar thing ("Stage selected: no motion blocks"), so this is for parity. Some people have gotten confused about this: https://www.reddit.com/r/turbowarp/comments/1adxxff/why_is_there_only_the_erase_block_in_pen_how_do_i/
And TurboWarp/scratch-blocks#9 got merged, so I assume minor tweaks like this can get accepted. (Though this one adds a string.)

Test Coverage

Haven't touched tests.

The motion category already does this, so this is for parity
@LilyMakesThings
Copy link

There are a lot of cases where the stage has less blocks, sometimes for ambiguous reasons. I think this is a good temporary fix but consideration should be made in the future to cover all cases where the stage is an exception to what's included in the categories.

@GarboMuffin GarboMuffin merged commit f201364 into TurboWarp:develop Feb 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants