Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler's waitPromise implementation #185

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Fix compiler's waitPromise implementation #185

merged 3 commits into from
Jan 21, 2024

Conversation

FurryR
Copy link

@FurryR FurryR commented Jan 17, 2024

Resolves

#184

Proposed Changes

  • Fix PromiseLike support in waitPromise() function
  • Fix unintended promise.catch usage in waitPromise() function

Reason for Changes

From #184:

  • Compiler's waitPromise soft-lock if promise handlers executed immediately.

Test Coverage

N/A

Note

It is recommended to merge this pull request by squash merge.

FurryR and others added 3 commits January 17, 2024 18:50
@FurryR
Fix compiler's waitPromise implementation
46b9766 
`waitPromise()` now finally allows PromiseLike
@FurryR
Avoid using promise.catch in waitPromise
72cdbc2 
`promise.catch` is not included in PromiseLike
@GarboMuffin
Add test for promise-like blocks
b3e621c
@GarboMuffin GarboMuffin merged commit 08eb399 into TurboWarp:develop Jan 21, 2024
1 check passed
@FurryR FurryR mentioned this pull request Jan 24, 2024
Closed
@GarboMuffin GarboMuffin linked an issue Jan 25, 2024 that may be closed by this pull request
Compiler's waitPromise soft-lock if promise handlers executed immediately #184
Closed
@FurryR FurryR mentioned this pull request Jan 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler's waitPromise soft-lock if promise handlers executed immediately
2 participants
@FurryR @GarboMuffin