From a15c069ac678258233e8683cfee6f7efd6bbe343 Mon Sep 17 00:00:00 2001
From: Muffin <muffin@mailbox.org>
Date: Fri, 26 Jan 2024 20:39:05 -0600
Subject: [PATCH] Improve promise-like extension block test

notably, fail on compiler errors, and run the test block several times
---
 .../tw-block-returning-promise-like.sb3       | Bin 2309 -> 2331 bytes
 .../tw_block_returning_promise_like.js        |   8 ++++++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/test/fixtures/tw-block-returning-promise-like.sb3 b/test/fixtures/tw-block-returning-promise-like.sb3
index d7c232ca21ab440b01d3d9cf9b8df4702dfa886b..4ef6f8076e6624ab2299ff625e9dae6c530fe199 100644
GIT binary patch
delta 1100
zcmV-S1he~v5}Oi#P)h>@3IG5A2mo0WJ6NXgy1upp006KI000aC003}uZ)#;@bS`Rh
zZ*H|#dvDt|5dSI#2O|mKd6FzAj{n)xJca^ETh!UGAqcV)dA3<gq(IV6yv*OdN6B*J
zyeg*{KpS_|@$Pp|@}4;`V|11cuI`z%LkDAI17~K~W(qQYqFK4uW^*tSk`zhyp8fOn
zboyKTpS=3%Z2IeN|8DQ-&(6=;;$0;~`dFQ92iMCsOQrRu?ukr{2EpNhPc@&eXs)vi
zRrQ6>j3Mq=TQ~E70xwX|CF&K-1o%`KoreTffP*t_GH~?4&d0O`)}s3$i02{-dtoes
zUN;<x(I|<3q9}+lK;A>qkAZ|U(Zf5}K(<pVH`;-dS{)NkG=H%{6bFxY|7L@*A1tri
z%<7pE9y`%<ofb}o0UbzTf##DDXbLYKX1QjAeIn;lpuRMqYz`C*zF>o1wN3ePJ^)%V
zf9B3z>S2z^C+DEXvm&2rmZr;gEx{v5Z7svOkq*OuM>%eoF9!Zk=UfY~%c1ocP+9W)
z#&e`rmC;OyEbx0q5F=GSs}znTrea0g2?%|=hUs*Ej&n>`8zdk$Y|=O7Zf+;2Mk$PW
zD)|(}gITDV^^tgk-LfI>D6!rBHlyf=-H_yQ14gR#)ZSQFtWB5J)-Ln9%k1KGI6V6O
zl<FXVY+r?xO;mziUvC?Vq;dFpJ^b(^;pdHQV%=u)cAIaV3adR|+lh1;<X_NI%lWpX
zBz|X7^bVs0aDUWKl0)7X{eB#TNiPN-(=<3p_Un`4d$KQ0ia35|P{eWLIT89PU}Z6K
z*Hs!6HA??h{#zXq(jYJWKJ=`C@wlAStB_ZJD28s~cNwJVJ1`yt^Jp@yq|;`FXPs})
zZ&m=SfBxgkc~R_}5`!Y{1ITmg)xzj6UttcG8=1Q{PbmehD7d6Er_~waTL<r3!I3Ab
zMK{+6HPS@w?ma6|Uk2UGJg?`aB}J?21$Q>!@3f-hh6;QY)>Le9vYfBw*;cP9;EmOP
z*v*$#+2L=)|Egb?i+rVa$PG9?>AbJDJI9|cE{;B){J15bup0Kt_RgC^dD8S$?^Q|C
z(|wYaC(2iF8`N|wIxALC7Ps#jpx<YsGimW$PSLBIfLF(<p}oKalt|GKC261vNw0@=
z(RsxPr!Myj@=~kc?4C4$R&$81X77-Hhv467XR3*7FQ8fLp!hruW`ngJ1eHV0wH$0w
zm)sY2(=`4cNVl!S?F^R&ivOyKA1;NC!7;rZ(d;U`Z9N+0yL&!yj4tsEUGaLfn9coV
z#=4!L6Zm&%MoiF&3Wi>+#q)tJm)`(TO9KQ70000809h0}ScuLL0h0g#0LlQ9;seJ6
zSrj|7tORib4p|gCSf=l~zP1AZ0I&>`D+nwDSrj{yS_m5f;FER;GXq%^JCm#k8v?Zi
Sle+{alkW%+1}6vr0001zL<sZ%

delta 1089
zcmV-H1it&55`_|fP)h>@3IG5A2moW8HCUB#2!Nmi0077f000aC003}uZ)#;@bS`Rh
zZ*H|#dvD`54F4(z4MAHV%WTJK)BLmb`WOyqcf+L{HWWoiOG=`PEg6!MHtX`;NBWUE
zeVyB3fD({2MgI7bbk984sq~JGuI`y~V-HiwM&2%Dmubj<kY=T<%a&jjB&kH*d-m7Y
z)A>*FKkDkcv-yv^!@Iqs-+SL@s}Hpj+G9<&8(gouELDzN-6NS;1A@Z?pBg@|Xl}Ah
z>iP>`Sc}}TaehI70#YdG5_JVL0X`Sj<RL;8;Ni^J3_N~t%PES$Iq5$M<hh8#K^Ti*
z&<`hKGD)I;C<<a3NIsBa7y~M2Vj%B)3*BC6+!_yF8GVd6rTv4AqBwXg{gaKtVX(gL
zGG`WA5O$=OCM|*r1Kg0pO4`p>NLxhdWtJN@+DCG!gfy2Hw95gL!B=cFsKr<xPYE!Z
z(VjbhX~wyfe0C0cx+v<Y7iqfgHVQm})HN!cTjgbc_^8G$>&1ZnOwNrUTV6WCAhpBD
zZ-_&)y2>V!1%6@@WR%VqwZVy!si<f-17U7AFulpo<x-}VfV^+{#BbW)+|Hz)q%h^F
z;&Uk;+(N@GW#S!v%YnGV!uI#O46`5hLu$<}7^yLHcjI8Sab0@bgbdA)*~RI2eDw1v
z_CeTxy$Z3KQVVu{{kBxRcUmeL)jUx?gZzth*oxGy7~D4|XmA)MAonN3Bst_mF&xH0
zm<(dzF;2-rvfrGbZ|S}?L2>-d0L5|Z`3Y${oGOl@P4$AJcKGkq-}NS;tmI|fhs0W#
zPRkRlN_mZ9>{ldZkftBN5(Y+SGNY9@w!*W2X?^0ihk-Re|Mum)Xo78xQIYo%<T>_m
z;q-^Eums1g%6*roSb|OzT;iV7dJpoQgO8oyh=_XOiT+7X3{ty$&nh&Rm40ELxAW3c
zqSGhEoh|q~o#?ow0qVkri8t&l&z*8_XV4b#)@mK*ORJpt_u+pvuFF+knH_Trp3i!J
zA8T>%`18fZ(Jv?e-4hk8fxY&<^R85$wB0p$RTJ&>pH$_E@d|E>p6*0v#R|&irl|q^
z{c267oIF=^N#<ri<~R;CDa=5NR9d7I9;ia$t(vZSuQ=g2<zyf)t&*^R(gIo|AiT0D
zAc8>emowcav=`89Y+!z#CbPxb90YY<K<%v@yrC~SHFn!F{vSx++J|p*TskQJ>mh!)
z6na)p@l7S|u9ml*M@RYY9u<z^C7wxNysDhcmUNl1elO?+^ghdw33^e%;7hJ}R<QN@
zUr<W}1PTBE00;nMoHdi}1JVOyoHet;1aSinW1KZum2n7wpaTE^$P1G}2rL6*oHdhh
z2pa*)lZ*&6AY+_0Situn=`aHT000O803-ka00000000000001=1e4JOCX)pT5C#zl
H00000j-dk(

diff --git a/test/integration/tw_block_returning_promise_like.js b/test/integration/tw_block_returning_promise_like.js
index a0e95e8c3e..e212ef4266 100644
--- a/test/integration/tw_block_returning_promise_like.js
+++ b/test/integration/tw_block_returning_promise_like.js
@@ -21,13 +21,13 @@ class TestExtension {
         };
     }
     test () {
-        // returns a PromiseLike that calls handler immediately.
+        // returns a PromiseLike that calls handler immediately instead of in next microtask.
         const promise = {
             then (callbackFn) {
                 callbackFn();
                 return promise;
             }
-            // intentionally omit catch() as that is not part of PromiseLike
+            // intentionally omit catch() as that is not part of PromiseLike, so it should not be used
         };
         return promise;
     }
@@ -45,6 +45,10 @@ for (const compilerEnabled of [false, true]) {
         });
         t.equal(vm.runtime.compilerOptions.enabled, compilerEnabled, 'sanity check');
 
+        vm.runtime.on('COMPILE_ERROR', () => {
+            t.fail('Compile error');
+        });
+
         vm.loadProject(fixture).then(() => {
             let ended = 0;
             vm.runtime.on('SAY', (target, type, text) => {