Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide base for modernisation #10

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

clbarnes
Copy link

Suggested: add a pyproject.toml to allow package to be built by pip without pre-installing compile-time dependencies (see PEP517/518). That would look like

[build-system]
requires = ["setuptools", "cython>=0.24", "numpy>=1.9,>1.12", "scipy<1.3", "wheel"]
build-backend = "setuptools.build_meta"

but given there are 2 layers of setup.py, I'm not sure which directory it would go into.

I haven't worked with C/C++/cython extensions before so I don't know how to fix the failures, but this at least provides a way to consistently test them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant