Update portal.json #20710
Update portal.json #20710
Conversation
Change to proper spanish syntax of a few fields.
| "Choose": "Elige", | ||
| "Choose a different plan": "Elige un plan diferente", | ||
| "Choose your newsletters": "Elige tus boletines", | ||
| "Choose your newsletters": "Elige tus boletínes", |
There was a problem hiding this comment.
is this a regional difference? I'm getting i (not í) as the correct spelling for the plural...
There was a problem hiding this comment.
Wrong there too. Boletín is only with accent, not in plural, which is only boletines.
| "Error": "Error", | ||
| "Expires {{expiryDate}}": "Expira el {{expiryDate}}", | ||
| "Forever": "para siempre", | ||
| "Expires {{expiryDate}}": "Expira él {{expiryDate}}", |
There was a problem hiding this comment.
Is this (él) correct?
There was a problem hiding this comment.
Just rechecked, El is indeed without accent. Sorry about that, consulted pronouns and the actual dictionary and definitions on the RAE dictionary. "Expira el {{expiryDate}}" like it is written.
There was a problem hiding this comment.
Those are the only two that are indeed wrong, the rest is fine.
There was a problem hiding this comment.
Thanks for confirming. If you could please update the PR, I'll be glad to mark it approved with your fixes.
There was a problem hiding this comment.
OK, so what you need to do is go back into the editor on this branch (fochoaog:patch-2), make the edits (follow the tutorial if needed), and then commit them. That should automatically update the PR.
|
Did quite an extensive review since You asked and finally did proof reading to all the portal.json file, it is checked against dictionary, syntaxis and what are technical terms in IT Science, but from a point of view that Is understandable to the end user. More than 1 hour of proof reading and translating and explaining in fewer words what needs to be known. Will do the full edit in brief. |
|
Thanks so much! I appreciate your work. Did you see my message about updating the PR, rather than attaching a file, please? While I've got you, there are a couple of spots with desabilitado -- should those be deshabilitado ? |
|
Yes, wait a bit until I merge it fully. Should not take much. Thanks. |
main...fochoa8:Ghost-1:patch-1 Follow that url. It has the full file translation. |
Here is the pull request: |
Change to proper spanish syntax of a few fields.
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
yarn test:allandyarn lint)We appreciate your contribution!