Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: split feature powerset job per crate #192

Merged
merged 1 commit into from
Oct 17, 2024
Merged

ci: split feature powerset job per crate #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ jobs:
command: test
args: --workspace --all-targets --all-features

test-features:
name: Run test suite with every feature combination
test-features-reqwest-middleware:
name: Run test suite for `reqwest-middleware` with every feature combination
runs-on: ubuntu-latest
steps:
- name: Checkout repository
Expand All @@ -38,7 +38,40 @@ jobs:
- name: Install cargo-hack
uses: taiki-e/install-action@cargo-hack
- name: test
run: cargo hack test --feature-powerset
run: cargo hack test --feature-powerset -p reqwest-middleware
test-features-retry:
name: Run test suite for `reqwest-retry` with every feature combination
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install Rust
uses: actions-rs/toolchain@v1
with:
toolchain: stable
profile: minimal
override: true
- name: Install cargo-hack
uses: taiki-e/install-action@cargo-hack
- name: test
run: cargo hack test --feature-powerset -p reqwest-retry
test-features-reqwest-tracing:
name: Run test suite for `reqwest-tracing` with every feature combination
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install Rust
uses: actions-rs/toolchain@v1
with:
toolchain: stable
profile: minimal
override: true
Comment on lines +64 to +69
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is deprecated;

Suggested change
- name: Install Rust
uses: actions-rs/toolchain@v1
with:
toolchain: stable
profile: minimal
override: true
- name: Install Rust
uses: dtolnay/rust-toolchain@stable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Let's fix this in a follow up PR

- name: Install cargo-hack
uses: taiki-e/install-action@cargo-hack
# Old opentelemetry features group to improve performance
- name: test
run: cargo hack test --feature-powerset -p reqwest-tracing --group-features opentelemetry_0_20,opentelemetry_0_21,opentelemetry_0_22

rustfmt:
name: Rustfmt
Expand Down
Loading