Match stable Semantic Conventions for HTTP Spans (take 2) #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eopb
force-pushed
the
latest-otel-keys-rebase
branch
from
d527cc9
to
8e2fd17
Compare
CryZe
reviewed
Apr 10, 2024
eopb
force-pushed
the
latest-otel-keys-rebase
branch
from
58a8e4c
to
55d0d0d
Compare
eopb
force-pushed
the
latest-otel-keys-rebase
branch
from
55d0d0d
to
2a8caf0
Compare
The stable [Semantic Conventions for HTTP Spans](https://opentelemetry.io/docs/specs/semconv/http/http-spans/) use different keys than the ones used in this crate. This changes them to match the keys as defined by the stable specification.
…`SpanBackendWithUrl`
eopb
force-pushed
the
latest-otel-keys-rebase
branch
from
2a8caf0
to
d2286b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #114 with tests fixed and deprecated items removed