Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins review fix #65

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Jenkins review fix #65

merged 1 commit into from
Aug 14, 2024

Conversation

souvik-karfa
Copy link
Contributor

@souvik-karfa souvik-karfa commented Aug 14, 2024 •
edited
Loading

Summary:

Issues Link: jenkins-infra/repository-permissions-updater#3977 (comment)

Fixes:

  • Replaced implements FileCallable with extends MasterToSlaveFileCallable. This places a role-check to make sure the Callable can only be called by the controller.
  • Replaced String with Secret for traceableToken in ApiInspectorStepBuilder.
  • Added suppress warnings for traceableCliKeyFileName.
  • Appended repoWorkspacePath before specFilePath if user provides the specFilePath.

Points to Note:

  • In case of ApiInspector, the machine should have curl and jq installed.

@dhruv-singhal-github dhruv-singhal-github merged commit c189b2e into main Aug 14, 2024
3 checks passed
@dhruv-singhal-github dhruv-singhal-github deleted the jenkins-reviews-fix branch August 14, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarth-gupta-traceable samarth-gupta-traceable Awaiting requested review from samarth-gupta-traceable samarth-gupta-traceable is a code owner

@dhruv-singhal-github dhruv-singhal-github Awaiting requested review from dhruv-singhal-github dhruv-singhal-github is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@souvik-karfa @dhruv-singhal-github