Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed rtol and atol from GD so that it doesn't do early stopping automatically #1944

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Removed rtol and atol from GD so that it doesn't do early stopping automatically #1944

wants to merge 2 commits into from

Conversation

MargaretDuff
Copy link
Member

@MargaretDuff MargaretDuff commented Oct 8, 2024 •
edited
Loading

Changes

Testing you performed

Please add any demo scripts to https://github.com/TomographicImaging/CIL-Demos/tree/main/misc

Related issues/links

Closes #1942

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@MargaretDuff MargaretDuff linked an issue Oct 8, 2024 that may be closed by this pull request
Remove early stopping from the Gradient descent algorithm #1942
Open
@MargaretDuff MargaretDuff self-assigned this Oct 8, 2024
@MargaretDuff
Copy link
Member Author

image
Can we also remove repeats

@MargaretDuff
Copy link
Member Author

image
Not true for GD

paskino
paskino reviewed Oct 15, 2024
View reviewed changes
Wrappers/Python/cil/optimisation/algorithms/GD.py Outdated
self.atol = atol

if self.rtol!=0 or self.atol!=0: # to be deprecated
warn('`rtol` and `atol` are deprecated. For early stopping, please use a callback (cil.optimisation.utilities.callbacks) instead', DeprecationWarning, stacklevel=2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no example callback we can use?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paskino paskino paskino left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@MargaretDuff MargaretDuff

Labels
None yet
Projects
CIL work
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove early stopping from the Gradient descent algorithm
2 participants
@MargaretDuff @paskino