Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing ipps.h by pinning ipp #1581

Closed
wants to merge 1 commit into from
Closed

fix missing ipps.h by pinning ipp #1581

wants to merge 1 commit into from

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Nov 21, 2023

Describe your changes

In the last few days tests started failing due to ipp=2021.10.0 (re)moving the ipps.h header.

Possible solutions:

  • pin to ipp=2021.9.0 (previous version, working)
  • drop ipps.h?

Describe any testing you have performed

Haven't fully tested, should check upstream (ipp) changelog in detail first. According to https://www.intel.com/content/www/us/en/docs/ipp/developer-guide-reference/2021-10/fftinit-r-fftinit-c.html, ipps.h should still exist in 2021.10. Maybe it's a bug in their latest release?

Link relevant issues

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@casperdcl casperdcl self-assigned this Nov 21, 2023
@casperdcl casperdcl added Waiting for review bug Something isn't working labels Nov 21, 2023
@casperdcl casperdcl marked this pull request as ready for review November 21, 2023 17:04
@casperdcl casperdcl mentioned this pull request Nov 21, 2023
15 tasks
@casperdcl
Copy link
Member Author

replaced by #1583

@casperdcl casperdcl closed this Nov 21, 2023
@casperdcl casperdcl deleted the pin-ipp branch November 22, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant