CAN: Request/response fixes #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinjaeger
requested changes
Aug 11, 2024
| if (result == 0) { | ||
| /* maintain unlocking semantics of previous iteration of this code */ | ||
| struct shared_buffer *sbuf = thingset_sdk_shared_buffer(); | ||
| k_sem_give(&sbuf->lock); |
There was a problem hiding this comment.
I'm wondering why we are unlocking the buffer here at all, as the shared buffer doesn't seem to be used by the thingset_can_send_inst function. Only at my phone at the moment, so it's difficult to check the entire code flow...
There was a problem hiding this comment.
It's somewhat lost in the mists of time now, but I think the rationale was that we only want to unlock the buffer once the message has been successfully sent. I agree that it's a bit odd. In truth, the whole thing probably wants a bit of a rethink, but I figured this approach at least wouldn't make things any worse.
martinjaeger
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things here:
timeout0)