Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated insertMulti #775

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LunarDevelopment
Copy link

Complete with fix for k warning.

Complete with fix for k warning.
Copy link
Collaborator

@avbdr avbdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly done :)

MysqliDb.php Outdated
@@ -780,6 +780,13 @@ public function insertMulti($tableName, array $multiInsertData, array $dataKeys
$autoCommit = (isset($this->_transaction_in_progress) ? !$this->_transaction_in_progress : true);
$ids = array();

$options = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use old Array() syntax since we still support old php version

MysqliDb.php Outdated
return $ids;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove all whitespace changes

Copy link
Collaborator

@avbdr avbdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem

MysqliDb.php Outdated
$this->rollback();
}
return false;
$id = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still should be return false; plus previous comments are not addressed

@LunarDevelopment
Copy link
Author

I've changed the return type back to suit - I can't tell whats wrong with spacing per previous comment ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants