-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unclaim gateway on delete #7356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can't comment on the code, but do we need end-to-end tests too?
pkg/webui/console/containers/delete-entity-header-modal/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/delete-entity-header-modal/index.js
Outdated
Show resolved
Hide resolved
I included e2e tests as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, I trust the end-to-end tests.
Shall we backport this to the current |
Yes |
Summary
Unclaim gateway on delete.
Changes
delete-entity-header-modal
component.Testing
Steps
Try deleting a managed gateway.
Results
The gateway should be unclaimed and then deleted.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.