Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video feed on firefox #7309

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix video feed on firefox #7309

merged 1 commit into from
Sep 16, 2024

Conversation

mjamescompton
Copy link
Contributor

Summary

On firefox the video feed would fail to load on QR component

Changes

  • When videoTracks[0].getSettings() fails on firefox get the first camera deviceId from navigator.mediaDevices.enumerateDevices()

Testing

Steps

Open QR scanner on either add device or add gateway views using the latest firefox browser

Results

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@mjamescompton mjamescompton added the bug Something isn't working label Sep 16, 2024
@mjamescompton mjamescompton self-assigned this Sep 16, 2024
@mjamescompton mjamescompton requested review from a team as code owners September 16, 2024 15:24
@github-actions github-actions bot added the ui/web This is related to a web interface label Sep 16, 2024
@mjamescompton mjamescompton changed the title Fix/video feed Fix video feed on firefox Sep 16, 2024
@mjamescompton mjamescompton changed the base branch from v3.32 to release/v3.32.1 September 16, 2024 15:26
Copy link
Contributor

@ryaplots ryaplots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, open a PR with this also in ENT

@mjamescompton mjamescompton merged commit 70e1ede into release/v3.32.1 Sep 16, 2024
15 checks passed
@mjamescompton mjamescompton deleted the fix/video-feed branch September 16, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants