Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim gateway via QR code (FE) #7294

Merged
merged 10 commits into from
Sep 12, 2024
Merged

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Sep 10, 2024

Summary

This PR add the claiming gateway via QR code to the gateway onboarding.

References #7270

Changes

  • Add gateway qr code parse to sdk and store
  • Update messages
  • Add qr code scan section and use qr code data in the form

Testing

Steps

Log into the console and scan a valid qr code in the gateway registration form.
See the data being filled into the form fields and claim the gateway.

Results
Screen.Recording.2024-09-10.at.14.55.49.mov

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the ui/web This is related to a web interface label Sep 10, 2024
@ryaplots ryaplots added this to the 2024 Q3 milestone Sep 10, 2024
@ryaplots ryaplots self-assigned this Sep 10, 2024
@ryaplots ryaplots requested a review from a team as a code owner September 10, 2024 12:58
@ryaplots ryaplots requested review from mjamescompton, PavelJankoski and a team and removed request for a team September 10, 2024 12:58
@vlasebian vlasebian force-pushed the feature/claim-gateways-using-qr-be branch from f5be211 to d780ef2 Compare September 10, 2024 13:20
@vlasebian vlasebian requested review from a team as code owners September 10, 2024 13:20
@vlasebian vlasebian requested review from nicholaspcr, KrishnaIyer and johanstokking and removed request for a team September 10, 2024 13:20
@ryaplots ryaplots force-pushed the feature/claim-gateway-via-qr-fe branch from a308abe to 704a7d3 Compare September 10, 2024 13:30
@ryaplots ryaplots force-pushed the feature/claim-gateway-via-qr-fe branch from 704a7d3 to 2dc3f16 Compare September 10, 2024 13:31
Base automatically changed from feature/claim-gateways-using-qr-be to v3.32 September 10, 2024 13:44
@ryaplots ryaplots force-pushed the feature/claim-gateway-via-qr-fe branch from e42e85d to 7b50257 Compare September 11, 2024 12:21
@KrishnaIyer KrishnaIyer merged commit 5bdc597 into v3.32 Sep 12, 2024
14 of 15 checks passed
@KrishnaIyer KrishnaIyer deleted the feature/claim-gateway-via-qr-fe branch September 12, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants