-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Claim gateway via QR code (FE) #7294
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryaplots
requested review from
mjamescompton,
PavelJankoski and
a team
and removed request for
a team
September 10, 2024 12:58
vlasebian
force-pushed
the
feature/claim-gateways-using-qr-be
branch
from
September 10, 2024 13:20
f5be211
to
d780ef2
Compare
vlasebian
requested review from
nicholaspcr,
KrishnaIyer and
johanstokking
and removed request for
a team
September 10, 2024 13:20
ryaplots
force-pushed
the
feature/claim-gateway-via-qr-fe
branch
from
September 10, 2024 13:30
a308abe
to
704a7d3
Compare
ryaplots
force-pushed
the
feature/claim-gateway-via-qr-fe
branch
from
September 10, 2024 13:31
704a7d3
to
2dc3f16
Compare
Base automatically changed from
feature/claim-gateways-using-qr-be
to
v3.32
September 10, 2024 13:44
ryaplots
force-pushed
the
feature/claim-gateway-via-qr-fe
branch
from
September 11, 2024 12:21
e42e85d
to
7b50257
Compare
PavelJankoski
approved these changes
Sep 12, 2024
mjamescompton
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add the claiming gateway via QR code to the gateway onboarding.
References #7270
Changes
Testing
Steps
Log into the console and scan a valid qr code in the gateway registration form.
See the data being filled into the form fields and claim the gateway.
Results
Screen.Recording.2024-09-10.at.14.55.49.mov
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.