Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collaborator validation #6807

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Fix collaborator validation #6807

merged 2 commits into from
Jan 8, 2024

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Jan 4, 2024

Summary

This PR fixes a validation bug in the collaborator form, also fixing the e2e tests

Changes

  • Update test function

Testing

  1. Log into the console
  2. Try creating a collaborator - should go through
  3. Try submitting the form without a collaborator - should be an error on the field saying the collaborator is required

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the ui/web This is related to a web interface label Jan 4, 2024
@ryaplots ryaplots added this to the v3.29.0 milestone Jan 4, 2024
@ryaplots ryaplots self-assigned this Jan 4, 2024
@ryaplots ryaplots requested a review from a team as a code owner January 4, 2024 12:14
@kschiffer kschiffer merged commit 4822a0c into v3.29 Jan 8, 2024
13 checks passed
@kschiffer kschiffer deleted the fix/collab-validation branch January 8, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants