Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues via sentry #6785

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Fix various issues via sentry #6785

merged 4 commits into from
Jan 8, 2024

Conversation

kschiffer
Copy link
Contributor

Summary

This quickfix PR addresses three minor issues that I've found via Sentry.

Changes

Testing

Manual testing and e2e

Notes for Reviewers

I'm not sure yet why the backend returns ABP end devices with empty session keys (maybe due to restricted rights)

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added bug Something isn't working c/console This is related to the Console ui/web This is related to a web interface labels Dec 21, 2023
@kschiffer kschiffer added this to the v3.29.0 milestone Dec 21, 2023
@kschiffer kschiffer self-assigned this Dec 21, 2023
@kschiffer kschiffer requested a review from a team as a code owner December 21, 2023 07:50
@kschiffer kschiffer merged commit 012f233 into v3.29 Jan 8, 2024
13 checks passed
@kschiffer kschiffer deleted the fix/sentry-fixes-2312 branch January 8, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants