-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring some class components in the Console #6485
Conversation
…-location Show gateway locations retrieved from status messages in the map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my small remark.
This includes a couple of more intricate refactors. Did you double-check that everything works also manually? Specifically wrt the Byte Input (eg. copy/paste, unbounded inputs, etc)
After speaking with Krishna, I am changing the base branch of this PR to |
Summary
References #6376
Changes
Testing
Create and application and check if the created application has the correct information;
Go to adding a device and complete the process all the way to the Join EUI step. Here, try a) adding the EUI manually, pasting the EUI, adding characters in the middle, pasting characters in the middle.
Create a webhook and add a Uplink path.
Import a device and make sure a successful import looks like this:
Open the Gateways list and click though the pagination making sure all the pages work well.
Open Applications list and switch between the tabs. There should be no errors and the Deleted tab should show deleted apps and the all tab should show all apps.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.