Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring some class components in the Console #6485

Merged
merged 14 commits into from
Aug 30, 2023
Merged

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Aug 29, 2023

Summary

References #6376

Changes

  • Refactor tab
  • Refactor pagination
  • Refactor progress bar
  • Refactor byte input
  • Refactor toggled input
  • Refactor code editor
  • Refactor radio buttons

Testing

  • Input fields:
    Create and application and check if the created application has the correct information;
  • Byte input fields (e.g. Join EUI field in the device onboarding):
    Go to adding a device and complete the process all the way to the Join EUI step. Here, try a) adding the EUI manually, pasting the EUI, adding characters in the middle, pasting characters in the middle.
  • Toggled input (webhook form):
    Create a webhook and add a Uplink path.
  • Progress bar (present in Device import):
    Import a device and make sure a successful import looks like this:
Screenshot 2023-08-30 at 16 22 27
  • Pagination component (present in entities list):
    Open the Gateways list and click though the pagination making sure all the pages work well.
  • Tab component:
    Open Applications list and switch between the tabs. There should be no errors and the Deleted tab should show deleted apps and the all tab should show all apps.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added c/console This is related to the Console ui/web This is related to a web interface labels Aug 29, 2023
@ryaplots ryaplots self-assigned this Aug 29, 2023
@github-actions github-actions bot removed the c/console This is related to the Console label Aug 29, 2023
@ryaplots ryaplots marked this pull request as ready for review August 29, 2023 13:25
Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my small remark.

This includes a couple of more intricate refactors. Did you double-check that everything works also manually? Specifically wrt the Byte Input (eg. copy/paste, unbounded inputs, etc)

pkg/webui/components/input/index.js Outdated Show resolved Hide resolved
@ryaplots
Copy link
Contributor Author

After speaking with Krishna, I am changing the base branch of this PR to v3.28, in order to not introduce possible errors or broken fields before the conference.

@ryaplots ryaplots changed the base branch from v3.27 to v3.28 August 30, 2023 13:33
@ryaplots ryaplots merged commit 039b1db into v3.28 Aug 30, 2023
13 checks passed
@ryaplots ryaplots deleted the fix/refactoring-work branch August 30, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants