Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RP2-1.0.4 support #6482

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Add RP2-1.0.4 support #6482

merged 8 commits into from
Aug 29, 2023

Conversation

adriansmares
Copy link
Contributor

@adriansmares adriansmares commented Aug 25, 2023

Summary

References https://github.com/TheThingsIndustries/lorawan-stack/issues/3743

Changes

  • Deduplicate common band parameters.
    • Some band parameters, like the default RX1 delay, are not really region specific - the regional parameters specification uses them for all of the bands in the specification, and in general they have not really changed between regional parameters versions.
    • Since we duplicate them a lot in the band definitions, but they are identical, I have extracted them into a SharedParameters struct that we can reference, and should the parameters change in a future RP document, we can use a single instance instead of defining them in each band.
  • Add RP2-1.0.4 support.
    • The support itself is required for the relay specification, as the relay parameters are introduced by RP2-1.0.4.
    • The RP2-1.0.4 specification has two features that are not implemented in this PR: adding extra channels to fixed channel regions like US915/AU915, and using the channel mask CFList in dynamic channel plan regions. Our current frequency plans do not require these features, and we can revisit them later on in case we want to support this functionality.
  • Fix CN4710-510 26 MHz beacon and ping channel frequencies.
    • This is mainly for completeness sake, as the 26 MHz bands have a simpler frequency description.
  • Add relay specification WOR channels to the appropriate regions in the RP2-1.0.4 specification.
    • 2.4GHz and the Morocco draft are intentionally left out, as they don't have a provided set of relay parameters. EU433 apparently has no relay parameters in RP2-1.0.4 - I do not know the reason for this.
  • Support the relay parameters in the band description RPCs.

Testing

Unit testing. Release specific testing is not required.

Regressions

The only retroactive changes affect the shared band parameters, which can be verified by inspecting the universalSharedParameters definition and comparing it against the RP2 document:

image

Notes for Reviewers

You can skip individual the Go band definitions and test data. Please only take a look at the structural changes.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.27.2 milestone Aug 25, 2023
@adriansmares adriansmares self-assigned this Aug 25, 2023
@github-actions github-actions bot added the ui/web This is related to a web interface label Aug 25, 2023
Copy link
Contributor

@ryaplots ryaplots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console part looks good to me.

Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looked only a few samples and skimmed through the rest.

@adriansmares adriansmares merged commit e374556 into v3.27 Aug 29, 2023
13 of 14 checks passed
@adriansmares adriansmares deleted the feature/rp2-1.0.4 branch August 29, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants