-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RP2-1.0.4 support #6482
Merged
Merged
Add RP2-1.0.4 support #6482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansmares
force-pushed
the
feature/rp2-1.0.4
branch
from
August 25, 2023 20:45
efd6825
to
7434bc6
Compare
adriansmares
requested review from
KrishnaIyer,
kschiffer,
ryaplots,
mjamescompton and
johanstokking
as code owners
August 25, 2023 21:12
johanstokking
approved these changes
Aug 29, 2023
ryaplots
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Console part looks good to me.
KrishnaIyer
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looked only a few samples and skimmed through the rest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References https://github.com/TheThingsIndustries/lorawan-stack/issues/3743
Changes
SharedParameters
struct that we can reference, and should the parameters change in a future RP document, we can use a single instance instead of defining them in each band.Testing
Unit testing. Release specific testing is not required.
Regressions
The only retroactive changes affect the shared band parameters, which can be verified by inspecting the
universalSharedParameters
definition and comparing it against the RP2 document:Notes for Reviewers
You can skip individual the Go band definitions and test data. Please only take a look at the structural changes.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.