Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NSID to network identifiers #6453

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Add NSID to network identifiers #6453

merged 6 commits into from
Aug 14, 2023

Conversation

johanstokking
Copy link
Member

Summary

Open source counterpart of https://github.com/TheThingsIndustries/lorawan-stack/pull/3811

This adds the NSID to network identifiers.

Changes

  • Add NSID to Network Server configuration and include in uplink message's network metadata
  • Use interop's NSID in Identity Server and return as part of HomeNSAns
  • Fix unrelated comments

Testing

CI

Regressions

None

Notes for Reviewers

Review in https://github.com/TheThingsIndustries/lorawan-stack/pull/3811 please.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@johanstokking johanstokking added this to the v3.28.0 milestone Aug 13, 2023
@johanstokking johanstokking self-assigned this Aug 13, 2023
@johanstokking johanstokking changed the base branch from v3.27 to v3.28 August 13, 2023 05:14
@github-actions github-actions bot added c/network server This is related to the Network Server c/identity server This is related to the Identity Server compat/config This could affect Configuration compatibility labels Aug 13, 2023
pkg/networkserver/networkserver.go Outdated Show resolved Hide resolved
@johanstokking johanstokking merged commit 11aff5f into v3.28 Aug 14, 2023
9 of 10 checks passed
@johanstokking johanstokking deleted the feature/nr-ids branch August 14, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/identity server This is related to the Identity Server c/network server This is related to the Network Server compat/config This could affect Configuration compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants