Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate current channels length #6445

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Validate current channels length #6445

merged 1 commit into from
Aug 8, 2023

Conversation

adriansmares
Copy link
Contributor

Summary

References #5399
References https://the-things-industries.sentry.io/issues/4349395436

Changes

  • Validate the length of the current channels in order to avoid panicing when too many current channels are generated.

Testing

Local testing.

Regressions

N/A. This fixes a corner case in the LinkADRReq generation that is a normal bounds check.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added the bug Something isn't working label Aug 7, 2023
@adriansmares adriansmares added this to the v3.27.1 milestone Aug 7, 2023
@adriansmares adriansmares self-assigned this Aug 7, 2023
@github-actions github-actions bot added c/network server This is related to the Network Server ui/web This is related to a web interface labels Aug 7, 2023
@adriansmares adriansmares marked this pull request as ready for review August 7, 2023 11:05
@adriansmares adriansmares merged commit abe92f6 into v3.27 Aug 8, 2023
15 checks passed
@adriansmares adriansmares deleted the fix/current-params branch August 8, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/network server This is related to the Network Server ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants