Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove withRequest and related selectors and refactor <Require /> #6443

Merged
merged 12 commits into from
Aug 14, 2023
Merged

Remove withRequest and related selectors and refactor <Require /> #6443

merged 12 commits into from
Aug 14, 2023

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Aug 4, 2023 •
edited
Loading

Summary

Remove with-request and other HOCs
Reference #6376

Changes

  • Remove with-request
  • Remove associated error and fetching selectors
  • Refactor other HOCs
  • Refactor rights group

Testing

manually and e2e

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@github-actions github-actions bot added the ui/web This is related to a web interface label Aug 4, 2023
@ryaplots ryaplots marked this pull request as ready for review August 4, 2023 14:28
Base automatically changed from fix/remove-with-request to v3.27 August 7, 2023 08:28
kschiffer
kschiffer requested changes Aug 7, 2023
View reviewed changes
Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! See my small remarks.

pkg/webui/components/rights-group/index.js Outdated Show resolved Hide resolved
pkg/webui/lib/hooks/use-computed-props.js Outdated Show resolved Hide resolved
@ryaplots ryaplots requested a review from kschiffer August 7, 2023 14:23
kschiffer
kschiffer approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my remarks.

pkg/webui/console/lib/components/require.js Outdated Show resolved Hide resolved
pkg/webui/lib/hooks/use-derived-rights-props.js Outdated Show resolved Hide resolved
pkg/webui/lib/hooks/use-derived-rights-props.js Outdated Show resolved Hide resolved
@kschiffer kschiffer assigned kschiffer and ryaplots and unassigned kschiffer Aug 14, 2023
@ryaplots ryaplots merged commit f1b6589 into v3.27 Aug 14, 2023
13 checks passed
@ryaplots ryaplots deleted the fix/refactor-components branch August 14, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschiffer kschiffer kschiffer approved these changes

@mjamescompton mjamescompton Awaiting requested review from mjamescompton mjamescompton is a code owner

Assignees

@ryaplots ryaplots

Labels
ui/web This is related to a web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryaplots @kschiffer