Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor table component #6442

Merged
merged 7 commits into from
Aug 7, 2023
Merged

Refactor table component #6442

merged 7 commits into from
Aug 7, 2023

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Aug 3, 2023 •
edited
Loading

Summary

Refactor some class components into functional components.
Reference: #6376

Changes

  • Refactor table components
  • Refactor Modal button
  • Refactor Key Value Map component

Testing

  • e2e

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots self-assigned this Aug 3, 2023
@ryaplots ryaplots added this to the v3.27.1 milestone Aug 3, 2023
@github-actions github-actions bot added the ui/web This is related to a web interface label Aug 3, 2023
@ryaplots ryaplots marked this pull request as ready for review August 4, 2023 09:55
kschiffer
kschiffer approved these changes Aug 7, 2023
View reviewed changes
pkg/webui/components/key-value-map/entry.js Outdated Show resolved Hide resolved
@ryaplots ryaplots merged commit f613532 into v3.27 Aug 7, 2023
13 checks passed
@ryaplots ryaplots deleted the fix/refactor-table-component branch August 7, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschiffer kschiffer kschiffer approved these changes

@mjamescompton mjamescompton Awaiting requested review from mjamescompton mjamescompton is a code owner

Assignees

@ryaplots ryaplots

Labels
ui/web This is related to a web interface
Projects
None yet
Milestone
v3.27.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ryaplots @kschiffer