Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement move away prompt in payload formatter views #6413

Merged
merged 10 commits into from
Aug 2, 2023
Merged

Reimplement move away prompt in payload formatter views #6413

merged 10 commits into from
Aug 2, 2023

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Aug 1, 2023 •
edited
Loading

Summary

Closes #6384

Changes

  • Use unstable_useBlocker
  • Update ConsoleApp to use RouterProvider
  • Refactor Payload Formatters Form
  • Add move away prompt container
Screenshot 2023-08-01 at 14 43 46

Testing

  1. Log in in Console.
  2. Go to any device payload foratter.
  3. Choose Formatter type - Custom Javascript formatter.
  4. Change something in the code editor.
  5. Go to overview or any other place, so move away from the payload formatter.
  6. See a prompt that warns you about the unsaved changes.

Notes for Reviewers

Using an unstable version of the useBlocker until react-router brings back usePrompt and useBlocker.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added this to the v3.27.1 milestone Aug 1, 2023
@ryaplots ryaplots self-assigned this Aug 1, 2023
@github-actions github-actions bot added the ui/web This is related to a web interface label Aug 1, 2023
@ryaplots ryaplots added the c/console This is related to the Console label Aug 1, 2023
@github-actions github-actions bot removed the c/console This is related to the Console label Aug 1, 2023
@ryaplots ryaplots marked this pull request as ready for review August 1, 2023 14:24
kschiffer
kschiffer approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

pkg/webui/console/containers/move-away-modal/move-away-modal.js Outdated Show resolved Hide resolved
@ryaplots ryaplots merged commit 7819785 into v3.27 Aug 2, 2023
12 of 13 checks passed
@ryaplots ryaplots deleted the fix/move-away-prompt branch August 2, 2023 12:38
@KrishnaIyer
Copy link
Member

@ryaplots: Could you please add a small comment on how this can be tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschiffer kschiffer kschiffer approved these changes

@mjamescompton mjamescompton Awaiting requested review from mjamescompton mjamescompton is a code owner

Assignees

@ryaplots ryaplots

Labels
ui/web This is related to a web interface
Projects
None yet
Milestone
v3.27.1
Development

Successfully merging this pull request may close these issues.

Reimplement accidental navigation prompt in payload formatter views
3 participants
@ryaplots @KrishnaIyer @kschiffer