Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Device importer class component and others #6400

Merged
merged 12 commits into from
Aug 1, 2023
Merged

Refactor Device importer class component and others #6400

merged 12 commits into from
Aug 1, 2023

Conversation

ryaplots
Copy link
Contributor

Summary

References #6376

Changes

  • Refactor Device importer
  • Refactor log back in modal
  • Refactor User Data Form
  • Refactor Device and Gateway Map
  • Refactor Toast component

Testing

e2e

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the c/console This is related to the Console label Jul 18, 2023
@ryaplots ryaplots added this to the v3.27.0 milestone Jul 18, 2023
@ryaplots ryaplots self-assigned this Jul 18, 2023
@github-actions github-actions bot added ui/web This is related to a web interface and removed c/console This is related to the Console labels Jul 18, 2023
@ryaplots ryaplots marked this pull request as ready for review July 18, 2023 12:10
kschiffer
kschiffer requested changes Jul 20, 2023
View reviewed changes
Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! See my remarks.

pkg/webui/components/toast/index.js Outdated Show resolved Hide resolved
pkg/webui/console/components/user-data-form/index.js Outdated Show resolved Hide resolved
pkg/webui/console/components/user-data-form/index.js Outdated Show resolved Hide resolved
pkg/webui/console/components/user-data-form/index.js Outdated Show resolved Hide resolved
@ryaplots ryaplots modified the milestones: v3.27.0, v3.27.1 Jul 20, 2023
@ryaplots ryaplots requested a review from kschiffer July 25, 2023 13:51
@ryaplots ryaplots requested a review from kschiffer July 26, 2023 09:45
@ryaplots ryaplots merged commit 07b7e7d into v3.27 Aug 1, 2023
13 checks passed
@ryaplots ryaplots deleted the fix/class-components-refactor branch August 1, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschiffer kschiffer kschiffer approved these changes

@mjamescompton mjamescompton Awaiting requested review from mjamescompton mjamescompton is a code owner

Assignees

@ryaplots ryaplots

Labels
ui/web This is related to a web interface
Projects
None yet
Milestone
v3.27.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ryaplots @kschiffer